test(scrolling): correctly treat TestBed.compileComponents as async #14922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
mmalerba
requested changes
Jan 23, 2019
Tests for cdk/scrolling previously assumed that Test.compileComponents completes synchronously, immediately instantiating components after calling the compile. This is not true, and the tests only work by coicidence. With ivy, this is not as lenient and starts failing.
jelbourn
force-pushed
the
scroll-sync-compile
branch
from
5e1e728 to
687a5ea
Compare
|
Added the missing |
mmalerba
approved these changes
Jan 23, 2019
mmalerba
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jan 25, 2019
…14922) Tests for cdk/scrolling previously assumed that Test.compileComponents completes synchronously, immediately instantiating components after calling the compile. This is not true, and the tests only work by coicidence. With ivy, this is not as lenient and starts failing.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for cdk/scrolling previously assumed that Test.compileComponents
completes synchronously, immediately instantiating components after
calling the compile. This is not true, and the tests only work by
coicidence. With ivy, this is not as lenient and starts failing.